Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 349633005: Expose FileList in Worker contexts. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
michaeln, kinuko, jsbell
CC:
blink-reviews, arv+blink, tzik, nhiroki, kinuko+fileapi, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose FileList in Worker contexts. The File API spec exposes FileList in both Window and Worker contexts, http://dev.w3.org/2006/webapi/FileAPI/#filelist-section Follow up and have the implementation also provide the latter. R=michaeln@chromium.org,jsbell@chromium.org BUG=339441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177456

Patch Set 1 #

Total comments: 4

Patch Set 2 : Test improvements #

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-06-30 10:33:37 UTC) #1
jsbell
lgtm but I'm not intimately familiar with the file tests and I'm not in OWNERS ...
6 years, 5 months ago (2014-07-01 16:37:18 UTC) #2
sof
On 2014/07/01 16:37:18, jsbell wrote: > lgtm but I'm not intimately familiar with the file ...
6 years, 5 months ago (2014-07-02 12:29:26 UTC) #3
michaeln
oh!! r/s lgtm2
6 years, 5 months ago (2014-07-02 23:38:06 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-03 05:14:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/349633005/20001
6 years, 5 months ago (2014-07-03 05:16:22 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 07:38:05 UTC) #7
Message was sent while issue was closed.
Change committed as 177456

Powered by Google App Engine
This is Rietveld 408576698