Issue 349623002: Make object accessors more const-correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349623002: Make object accessors more const-correct. (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make object accessors more const-correct. Getting closer to making our IsFOO and FOO::cast methods const-correct... R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21897

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -88 lines)			Patch
M	src/objects.h	View	26 chunks	+37 lines, -37 lines	2 comments	Download
M	src/objects-inl.h	View	26 chunks	+54 lines, -50 lines	0 comments	Download
M	src/spaces.h	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

https://codereview.chromium.org/349623002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/349623002/diff/1/src/objects.h#newcode854 src/objects.h:854: inline void set_##name(type* value, \ I guess it's not ...

6 years, 6 months ago (2014-06-20 09:45:20 UTC) #3

Sven Panne

6 years, 6 months ago (2014-06-20 10:21:58 UTC) #4

Sven Panne

6 years, 6 months ago (2014-06-20 10:31:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r21897 (presubmit successful).

Expand Messages | Collapse Messages