test-parsing: Add functionality to specify "always true flags".

test-parsing: Add functionality to specify "always true flags".

Many parsing tests need to pin a certain flag, and apart from the pinned flag,
we want to keep the "test with all combinations" behavior for the non-pinned
flags.

R=ulan@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=21900

[marja, 2014-06-20 11:42:03]

ulan, ptal.

aperez@igalia, FYI, this should make your stuff easier, too.

[ulan, 2014-06-20 11:47:10]

https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc#...
test/cctest/test-parsing.cc:1490: generated_flags = new ParserFlag[flags_len -
always_true_flags_len];
How do you know that flags_len > always_true_flags_len if it flags wasn't NULL?

[marja, 2014-06-20 12:02:43]

https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc#...
test/cctest/test-parsing.cc:1490: generated_flags = new ParserFlag[flags_len -
always_true_flags_len];
On 2014/06/20 11:47:10, ulan wrote:
> How do you know that flags_len > always_true_flags_len if it flags wasn't
NULL?

I was assuming that always_true_flags are always contained in flags, but that's
probably a stupid assumption in the case when we're not using the default flags.

I fixed it so that you can pass flags and always_true_flags separately now, and
the removal is only done if we're using default_flags.

[ulan, 2014-06-20 12:08:04]

On 2014/06/20 12:02:43, marja wrote:
> https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc
> File test/cctest/test-parsing.cc (right):
> 
>
https://codereview.chromium.org/349603004/diff/1/test/cctest/test-parsing.cc#...
> test/cctest/test-parsing.cc:1490: generated_flags = new ParserFlag[flags_len -
> always_true_flags_len];
> On 2014/06/20 11:47:10, ulan wrote:
> > How do you know that flags_len > always_true_flags_len if it flags wasn't
> NULL?
> 
> I was assuming that always_true_flags are always contained in flags, but
that's
> probably a stupid assumption in the case when we're not using the default
flags.
> 
> I fixed it so that you can pass flags and always_true_flags separately now,
and
> the removal is only done if we're using default_flags.

OK, lgtm.

[marja, 2014-06-20 12:28:19]

Committed patchset #2 manually as r21900 (presubmit successful).

[aperez, 2014-06-23 15:26:35]

On 2014/06/20 11:42:03, marja wrote:
> ulan, ptal.
> 
> aperez@igalia, FYI, this should make your stuff easier, too.

Indeed, thanks!