[SyncFS] Use pointers to MetadataDatabaseIndexInterface

[SyncFS] Use pointers to MetadataDatabaseIndexInterface
instead of pointers to MetadataDatabaseIndex to enable injections.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278690

[peria, 2014-06-20 03:43:35]

PTL.

[tzik, 2014-06-20 03:57:47]

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
(right):

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:15:
#include "chrome/browser/sync_file_system/drive_backend/metadata_database.h"
Not sure but can we remove metadata_database.h #include?

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:25: //
Maintains indexes of MetadataDatabase on memory
please add '.' to the EOL here.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:32: //
NULL.
Could you remove these comments for overridden functions?

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h
(right):

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h:44:
#endif  // COMPILER
Can we move this block to the original file? I think this is only for on-memory
index.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h:55:
// entries on memory nor on disk.
Could you update this comment? I think this is no longer true or is going to be
not true.
Just removing second sentence is fine.

[peria, 2014-06-20 04:44:23]

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
(right):

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:15:
#include "chrome/browser/sync_file_system/drive_backend/metadata_database.h"
On 2014/06/20 03:57:47, tzik wrote:
> Not sure but can we remove metadata_database.h #include?

Done.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:25: //
Maintains indexes of MetadataDatabase on memory
On 2014/06/20 03:57:47, tzik wrote:
> please add '.' to the EOL here.

Done.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.h:32: //
NULL.
On 2014/06/20 03:57:47, tzik wrote:
> Could you remove these comments for overridden functions?

Done.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h
(right):

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h:44:
#endif  // COMPILER
On 2014/06/20 03:57:47, tzik wrote:
> Can we move this block to the original file? I think this is only for
on-memory
> index.

Done.

https://codereview.chromium.org/349543003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h:55:
// entries on memory nor on disk.
On 2014/06/20 03:57:47, tzik wrote:
> Could you update this comment? I think this is no longer true or is going to
be
> not true.
> Just removing second sentence is fine.

Done.

[tzik, 2014-06-20 04:47:49]

lgtm

[nhiroki, 2014-06-20 05:01:54]

lgtm

[peria, 2014-06-20 05:02:32]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-20 05:04:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/349543003/40001

[commit-bot: I haz the power, 2014-06-20 11:41:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 13:03:24]

Change committed as 278690