Load the calculator app by default

Load the calculator app by default

BUG=None
R=oshima@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278673

[oshima, 2014-06-19 23:28:27]

https://codereview.chromium.org/349493003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/349493003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:43: kDefaultAppPath);
what if the directory does not exist? Just want to make sure it wont fail to
start on the device.

[Jun Mukai, 2014-06-19 23:34:18]

https://codereview.chromium.org/349493003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/349493003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:43: kDefaultAppPath);
On 2014/06/19 23:28:27, oshima wrote:
> what if the directory does not exist? Just want to make sure it wont fail to
> start on the device.

Oops, didn't notice shell_extension_system has a CHECK -- added a check on
athena_main side so that it attempts to load the extension only when it exists.
In other cases (like the directory exists but no app info there), it just fails
to load. Errors messages are printed but it still works.

[oshima, 2014-06-19 23:36:24]

lgtm

[Jun Mukai, 2014-06-20 00:19:08]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-06-20 00:21:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/349493003/20001

[commit-bot: I haz the power, 2014-06-20 05:57:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-20 11:22:35]

Change committed as 278673