[Android] Map raw touch coordinates to global gesture locations

[Android] Map raw touch coordinates to global gesture locations

With r277082, raw touch locations are now exposed to the gesture detector.
Plumb these raw locations into the generated gesture events, in turn populating
the WebGestureEvent.global{X,Y} properties.

BUG=383690
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278672

[jdduke (slow), 2014-06-19 18:10:47]

tdresser@: PTAL. This was a bit more wiring than I would have liked, but I was
able to consolidate a few methods along the way (half the new code is unit
tests, so the line count change isn't actually too bad).  It is a bit of a shame
that this addition to GestureEventData is redundant with some bits in
ui::GestureEvent... maybe some day down the road we can simplify the basic
ui::Event derivatives and get rid of GestureEventData entirely.

[tdresser, 2014-06-19 21:12:37]

https://codereview.chromium.org/349463002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/349463002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/web_input_event_util.cc:242: gesture.globalY
= data.raw_y;
The ui::GestureEvent |root_location| should be passed to the WebGestureEvent as
globalX and globalY, shouldn't they?

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

might as well do that at the same time.

https://codereview.chromium.org/349463002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/gesture_provider.cc (right):

https://codereview.chromium.org/349463002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/gesture_provider.cc:61: touch_point_count,
I believe that the static_cast is required for some platforms.

[tdresser, 2014-06-19 21:39:10]

LGTM.

[jdduke (slow), 2014-06-19 21:43:30]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2014-06-19 21:43:34]

https://codereview.chromium.org/349463002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/349463002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/web_input_event_util.cc:242: gesture.globalY
= data.raw_y;
On 2014/06/19 21:12:37, tdresser wrote:
> The ui::GestureEvent |root_location| should be passed to the WebGestureEvent
as
> globalX and globalY, shouldn't they?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...
> 
> might as well do that at the same time.
> 
>  

Looks like we already populate that value:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

https://codereview.chromium.org/349463002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/gesture_provider.cc (right):

https://codereview.chromium.org/349463002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/gesture_provider.cc:61: touch_point_count,
On 2014/06/19 21:12:37, tdresser wrote:
> I believe that the static_cast is required for some platforms. 

Done.  (moved the cast into the GestureEventData constructor impl).

[commit-bot: I haz the power, 2014-06-19 21:45:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/349463002/20001

[jdduke (slow), 2014-06-20 03:55:32]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-06-20 03:55:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/349463002/40001

[commit-bot: I haz the power, 2014-06-20 11:19:51]

Change committed as 278672