Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 349453002: Remove IsRunningOnIOS6OrLater (Closed)

Created:
6 years, 6 months ago by stuartmorgan
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove IsRunningOnIOS6OrLater iOS 5 hasn't been supported for several releases, so this is always true. BUG=300130 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M base/ios/device_util.mm View 1 chunk +2 lines, -6 lines 0 comments Download
M base/ios/device_util_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M base/ios/ios_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/ios/ios_util.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/consumer/base/util.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/public/consumer/base/util.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
Rohit for full review Nico for base owners
6 years, 6 months ago (2014-06-19 18:04:42 UTC) #1
Nico
lgtm
6 years, 6 months ago (2014-06-19 18:10:00 UTC) #2
rohitrao (ping after 24h)
lgtm
6 years, 6 months ago (2014-06-19 18:24:49 UTC) #3
rohitrao (ping after 24h)
The CQ bit was checked by rohitrao@chromium.org
6 years, 6 months ago (2014-06-19 18:25:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/349453002/1
6 years, 6 months ago (2014-06-19 18:27:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:49:59 UTC) #6
Message was sent while issue was closed.
Change committed as 278519

Powered by Google App Engine
This is Rietveld 408576698