Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 349443002: PPAPI: Move PPB_TraceEvent to have dev-channel permissions (Closed)

Created:
6 years, 6 months ago by dmichael (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
teravest
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

PPAPI: Move PPB_TraceEvent to have dev-channel permissions PPB_TraceEvent should be available to developers who want to profile their application on Dev channel or Canary. BUG=386636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmichael (off chromium)
6 years, 6 months ago (2014-06-19 17:39:37 UTC) #1
teravest
lgtm Thanks for the quick turnaround. This seems like the most straightforward approach.
6 years, 6 months ago (2014-06-19 17:40:15 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 6 months ago (2014-06-19 17:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/349443002/1
6 years, 6 months ago (2014-06-19 17:46:58 UTC) #4
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 6 months ago (2014-06-19 17:47:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/349443002/1
6 years, 6 months ago (2014-06-19 17:48:49 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:53:52 UTC) #7
Message was sent while issue was closed.
Change committed as 278499

Powered by Google App Engine
This is Rietveld 408576698