Issue 349413004: Fix output_dir argument to blink_idl_parser.py in BUILD.gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349413004: Fix output_dir argument to blink_idl_parser.py in BUILD.gn (Closed)

Created:
6 years, 6 months ago by Jens Widell

Modified:
6 years, 6 months ago

Reviewers:
Nils Barth (inactive), haraken, brettw, philipj_slow

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Fix output_dir argument to blink_idl_parser.py in BUILD.gn Should be bindings_scripts_output_dir, not bindings_output_dir. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176841

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/scripts/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Jens Widell

The explicit rebuild of parsetab.pickle was broken in GN builds because of this, I think. ...

6 years, 6 months ago (2014-06-24 14:01:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/349413004/1

6 years, 6 months ago (2014-06-24 14:16:39 UTC) #4

f(malita)

6 years, 6 months ago (2014-06-24 14:50:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r176841 (presubmit successful).