Issue 349413002: Revert of Roll libvpx 278497:278986

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349413002: Revert of Roll libvpx 278497:278986 (Closed)

Created:
6 years, 6 months ago by mcasas

Modified:
6 years, 6 months ago

Reviewers:
Ronghua Wu (Left Chromium), fgalligan1, Tom Finegan, fgalligan

CC:
chromium-reviews, scherkus (not reviewing), xhwang, bankoski, hkuang, jzern

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Roll libvpx 278497:278986 (https://codereview.chromium.org/348113004/) Reason for revert: Suspected compile problem, f.i. [1] ninja -C /b/build/slave/mac/build/src/out/Release ninja: Entering directory `/b/build/slave/mac/build/src/out/Release' ninja: error: '../../third_party/libvpx/source/libvpx-internal/vp8/encoder/x86/quantize_sse4.asm', needed by 'gen/third_party/libvpx/quantize_sse4.o', missing and no known rule to make it program finished with exit code 1 elapsedTime=2.565863 [1] http://master.chrome.corp.google.com:8010/builders/mac/builds/2820/steps/compile/logs/stdio Original issue's description: > Roll libvpx 278497:278986 > > See https://codereview.chromium.org/341293003 > https://codereview.chromium.org/343233003/ > https://codereview.chromium.org/341353002/ > https://codereview.chromium.org/341343004/ > https://codereview.chromium.org/350543003/ > for the actual changes. > > BUG=386801 > R=ronghuawu@chromium.org, tomfinegan@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279262 TBR=tomfinegan@chromium.org,fgalligan@chromium.org,ronghuawu@chromium.org,fgalligan@google.com NOTREECHECKS=true NOTRY=true BUG=386801 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279353

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/349413002/1

6 years, 6 months ago (2014-06-24 08:25:18 UTC) #2

Tom Finegan

6 years, 6 months ago (2014-06-24 16:37:57 UTC) #4

Message was sent while issue was closed.

On 2014/06/24 08:26:24, I haz the power (commit-bot) wrote:
> Change committed as 279353

Sigh. Rolling libvpx is difficult: lgtm.