Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 349333006: Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel. I don't know if there are any v8 bots with that configuration, but it seems like a good idea to have v8 be consistent with chromium and nacl here, so that this works fine if such a bot is ever set up. This is similar to https://codereview.chromium.org/342493002/ , but with a detect_v8_host_arch.py script that handles the additional machine types that standalone.gypi used to handle. Originally reviewed at https://codereview.chromium.org/346643002/ BUG=368384 LOG=Y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21956

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M Makefile.android View 1 1 chunk +1 line, -1 line 0 comments Download
M Makefile.nacl View 1 2 1 chunk +1 line, -1 line 0 comments Download
A build/detect_v8_host_arch.py View 1 chunk +68 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 6 months ago (2014-06-24 04:39:57 UTC) #1
jochen (gone - plz use gerrit)
On 2014/06/24 at 04:39:57, thakis wrote: > lgtm I also fixed Makefile for you
6 years, 6 months ago (2014-06-24 07:12:23 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-24 07:13:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698