Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 34933002: Split components_tests into a separate gyp file (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 2 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Split components_tests into a separate gyp file This enables us to depend on components from shell, since components_tests already depends on shell. BUG=none R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230124

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -241 lines) Patch
M build/all.gyp View 8 chunks +8 lines, -8 lines 0 comments Download
M build/all_android.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A + components/components_tests.gyp View 4 chunks +29 lines, -23 lines 0 comments Download
D components/components_tests.gypi View 1 chunk +0 lines, -207 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-22 10:15:38 UTC) #1
Jói
Diff upload seems to have failed, can you try again? Which components are you planning ...
7 years, 2 months ago (2013-10-22 10:23:46 UTC) #2
jochen (gone - plz use gerrit)
ptal I want to use breakpad from content shell. content shell is technically a content ...
7 years, 2 months ago (2013-10-22 11:07:53 UTC) #3
Jói
LGTM I agree that using components from content shell is not dirty in the conceptual ...
7 years, 2 months ago (2013-10-22 11:14:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/34933002/110001
7 years, 2 months ago (2013-10-22 14:00:00 UTC) #5
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-22 14:19:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r230124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698