Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 349323003: [Android]: Replace calls to getdtablesize with sysconf(_SC_OPEN_MAX) in tools. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 4 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, Daniel Bratell
Project:
chromium
Visibility:
Public.

Description

[Android]: Replace calls to getdtablesize with sysconf(_SC_OPEN_MAX) in tools. The getdtablesize functions has been deprecated by Posix and has been removed from Android's LB64 ABI. Replace calls to it with the modern equivalent sysconf(_SC_OPEN_MAX). This fixes a build breakage in tryserver.blink/builders/android_blink_compile_rel/dbg. BUG=354405 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/test/multiprocess_test_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/adb_reboot/adb_reboot.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rmcilroy
TBRing to fix the blink trybots.
6 years, 5 months ago (2014-06-28 11:47:03 UTC) #1
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 5 months ago (2014-06-28 11:47:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/349323003/1
6 years, 5 months ago (2014-06-28 11:48:28 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-28 13:46:23 UTC) #4
commit-bot: I haz the power
Change committed as 280533
6 years, 5 months ago (2014-06-28 20:54:46 UTC) #5
navabi1
lgtm
6 years, 5 months ago (2014-06-30 20:00:27 UTC) #6
Paweł Hajdan Jr.
6 years, 4 months ago (2014-07-28 11:47:01 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698