Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tests/PictureTest.cpp

Issue 349313004: No one uses SkPicture::swap. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPicture.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PictureTest.cpp
diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp
index 6969524bd7156d049cf7dd611ac2d8de86de541e..c554a1223ebacc2cd909e42822665548de63cbc4 100644
--- a/tests/PictureTest.cpp
+++ b/tests/PictureTest.cpp
@@ -1561,16 +1561,6 @@ static void test_gen_id(skiatest::Reporter* reporter) {
SkPicture emptyCopy(empty);
REPORTER_ASSERT(reporter, empty.uniqueID() != emptyCopy.uniqueID());
- // test out swap
- {
- SkPicture swapWithData;
- uint32_t beforeID1 = swapWithData.uniqueID();
- uint32_t beforeID2 = copyWithData.uniqueID();
- swapWithData.swap(copyWithData);
- REPORTER_ASSERT(reporter, copyWithData.uniqueID() == beforeID1);
- REPORTER_ASSERT(reporter, swapWithData.uniqueID() == beforeID2);
- }
-
// test out clone
{
SkAutoTUnref<SkPicture> cloneWithData(hasData->clone());
« no previous file with comments | « src/core/SkPicture.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698