Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: mojo/shell/shell_test_base.h

Issue 349303006: mojo: add some end-to-end shell tests and a new test sample app (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no icu Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/test_service/test_time_service_impl.cc ('k') | mojo/shell/shell_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell_test_base.h
diff --git a/mojo/shell/shell_test_base.h b/mojo/shell/shell_test_base.h
index 69cc2c68e80f98e7748aaae581b19b8e73a6f8e1..52538a7eb67f379f0e0338a05a1dd704932328a2 100644
--- a/mojo/shell/shell_test_base.h
+++ b/mojo/shell/shell_test_base.h
@@ -24,10 +24,11 @@ class ShellTestBase : public testing::Test {
ShellTestBase();
virtual ~ShellTestBase();
- // Launches the given service in-process; |service_url| should typically be a
- // mojo: URL (the origin will be set to an "appropriate" file: URL).
- ScopedMessagePipeHandle LaunchServiceInProcess(
- const GURL& service_url,
+ // |application_url| should typically be a mojo: URL (the origin will be set
+ // to an "appropriate" file: URL).
+ // TODO(tim): Should the test base be a ServiceProvider?
+ ScopedMessagePipeHandle ConnectToService(
+ const GURL& application_url,
const std::string& service_name);
base::MessageLoop* message_loop() { return &message_loop_; }
« no previous file with comments | « mojo/services/test_service/test_time_service_impl.cc ('k') | mojo/shell/shell_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698