Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: child_job.h

Issue 3493012: Security patches: RestartJob ignores pid, argv[0]; kill runs as child UID (Closed) Base URL: http://git.chromium.org/git/login_manager.git
Patch Set: added comments, using -1 as suid in setresuid() calls Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | child_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: child_job.h
diff --git a/child_job.h b/child_job.h
index d3647f67acbad490d297f23d9753c0ab74c32c9d..ae0e75f263f95fba68d4b8b39390ab85378ae815 100644
--- a/child_job.h
+++ b/child_job.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009-2010 The Chromium OS Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -73,7 +73,7 @@ class ChildJob : public ChildJobInterface {
explicit ChildJob(const std::vector<std::string>& arguments);
virtual ~ChildJob();
- // Overridden from ChildJob
+ // Overridden from ChildJobInterface
virtual bool ShouldStop() const;
virtual void RecordTime();
virtual void Run();
@@ -137,4 +137,3 @@ class ChildJob : public ChildJobInterface {
} // namespace login_manager
#endif // LOGIN_MANAGER_CHILD_JOB_H_
-
« no previous file with comments | « no previous file | child_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698