Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 3493003: Updated split configs based on newer version of Kconfigs (Closed)

Created:
10 years, 3 months ago by Simon Que
Modified:
9 years, 7 months ago
Reviewers:
Olof Johansson, bfreed
CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Mandeep Singh Baines, vb
Visibility:
Public.

Description

CHROMIUM: config: Updated split configs based on newer version of Kconfigs Signed-off-by: Simon Que <sque@chromium.org>; Change-Id: I1116f7286e9c1417825cfe8b42db1697a39ca956 BUG=none TEST=none UPDATE: Fixed in http://codereview.chromium.org/3664003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chromeos/config/config.common.chromeos View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/config/i386/config.common.i386 View 3 chunks +2 lines, -1 line 0 comments Download
M chromeos/config/x86_64/config.common.x86_64 View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Simon Que
10 years, 3 months ago (2010-09-21 22:51:05 UTC) #1
Olof Johansson
LGTM. Thanks!
10 years, 3 months ago (2010-09-21 23:08:31 UTC) #2
Olof Johansson
Oh wait, one nitpick: Please update the description (the first line) in the commit to ...
10 years, 3 months ago (2010-09-21 23:09:29 UTC) #3
bfreed
That is not needed, is it Olof? chromeos/config files are not really upstreamed, are they? ...
10 years, 3 months ago (2010-09-21 23:27:14 UTC) #4
Olof Johansson
10 years, 3 months ago (2010-09-22 01:05:20 UTC) #5
On 2010/09/21 23:27:14, bfreed wrote:
> That is not needed, is it Olof?  chromeos/config files are not really
> upstreamed, are they?

It greatly helps to keep a consistent format to get a decent overview when
looking at shortlogs of the changes, such as through gitweb. So even though
these things are not upstreamed, keeping prefixes is a good idea.

-Olof

Powered by Google App Engine
This is Rietveld 408576698