Issue 349293010: Deprecate HTTP/2 PAD_HIGH field and enforce max padding size to 256 octets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349293010: Deprecate HTTP/2 PAD_HIGH field and enforce max padding size to 256 octets. (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Deprecate HTTP/2 PAD_HIGH field and enforce max padding size to 256 octets. 1. Replaced *_FLAG_PAD_LOW and *_FLAG_PAD_HIGH flags with *_FLAG_PADDED; 2. Reduce the size of pad length field from two octets to one octet (deprecated pad_high field); 3. Enforce the max padding size to be 256 octets. This lands server change 69870499 by raullenchai. BUG=

Patch Set 1 #

Patch Set 2 : nullptr => NULL. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -140 lines)			Patch
M	net/spdy/spdy_framer.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View		9 chunks	+39 lines, -65 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1	18 chunks	+30 lines, -46 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View		5 chunks	+12 lines, -22 lines	0 comments	Download
M	net/spdy/spdy_protocol.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages