Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 349293006: Revert of Enable FIXED_POINT and -O3 for Opus when building for ARM. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
CC:
chromium-reviews, minyue
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Enable FIXED_POINT and -O3 for Opus when building for ARM. (https://codereview.chromium.org/315673002/) Reason for revert: Media tests started failing consistently after this: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%281%29?numbuilds=200 It doesn't look super related, but the <() / >() change in common.gypi looks a bit suspicious, so revert this speculatively and see if it helps. Original issue's description: > - Enable FIXED_POINT for Opus when building for arm64. This yields: > ~21% speed up over floating point. > 2.6% increase in executable size. > - Also switched to late expansion of release_optimize in common.gypi (debug_optimize was already using it). This makes it possible to set optimization level via release_optimize in lower level targets. > > - Enable -O3 for Opus when building form arm32/arm64. This yields: > arm32: Speed increase up to 21% (encode) and 5% (decode). > arm32: 2.8% increase in executable size. > arm32: Output is bit exact with the output when -Os is used. > arm64: Speed increase up to 18% (encode) and 25% (decode). > arm64: 7.4% increase in executable size. > arm64: Output is exact within one LSB (max difference is 2) with the arm32 output. > > Measured using webrtc/audio_codec_speed_tests. > > BUG=chromium:354539 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277414 TBR=tlegrand1, Sergey Ulanov, Solis NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/opus.gyp View 2 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Created Revert of Enable FIXED_POINT and -O3 for Opus when building for ARM.
6 years, 6 months ago (2014-06-23 22:08:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/349293006/1
6 years, 6 months ago (2014-06-23 22:11:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 22:11:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-23 22:11:18 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 6 months ago (2014-06-23 22:13:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/349293006/1
6 years, 6 months ago (2014-06-23 22:15:05 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 22:20:23 UTC) #7
Message was sent while issue was closed.
Change committed as 279198

Powered by Google App Engine
This is Rietveld 408576698