ARM: sligthly reduce deopt tables size

ARM: sligthly reduce deopt tables size

BUG=

R=ulan@chromium.org, bmeurer@chromium.org

[vincent.belliard, 2014-06-23 11:14:02]

Port of r21608 (ARM64).
Factorize some instructions in deopt table. Load deopt address as an address +
offset.

No modification for benchmarks.

[ulan, 2014-06-23 11:41:40]

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:360: __ add(scratch0(), scratch0(),
Any reason you didn't move this out of the loop like it is done in r21608?

[vincent.belliard, 2014-06-23 11:52:29]

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:360: __ add(scratch0(), scratch0(),
Both versions generate the same number of instructions. I left in the loop
because that what was done before for ARM (and I think it's a little bit easier
to read).
Do you want me to put it out of the loop?

[ulan, 2014-06-23 12:04:08]

On 2014/06/23 11:52:29, vincent.belliard.arm wrote:
>
https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc
> File src/arm/lithium-codegen-arm.cc (right):
> 
>
https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm....
> src/arm/lithium-codegen-arm.cc:360: __ add(scratch0(), scratch0(),
> Both versions generate the same number of instructions. I left in the loop
> because that what was done before for ARM (and I think it's a little bit
easier
> to read).
> Do you want me to put it out of the loop?

I just asked to make sure I didn't miss anything. Both versions lgtm. For the
sake of consistency, it would be good to choose one version use it for both
architectures.

[vincent.belliard, 2014-06-24 14:28:17]

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:360: __ add(scratch0(), scratch0(),
On 2014/06/23 11:41:40, ulan wrote:
> Any reason you didn't move this out of the loop like it is done in r21608?

Done.

[vincent.belliard, 2014-07-09 08:23:08]

Is it still lgtm after this modification?

[ulan, 2014-07-09 08:34:00]

On 2014/07/09 08:23:08, vincent.belliard.arm wrote:
> Is it still lgtm after this modification?

Sorry, I missed the second patch. Yes, it lgtm.

[vincent.belliard, 2014-07-09 14:25:20]

committed r22305