Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 349233004: Remove suppression of distantclip image differences (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
rmistry, rmistry1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove suppression of distantclip image differences Committed: https://skia.googlesource.com/skia/+/c8fd7b58c5c4004a7be73894c6b04eeabf932c23

Patch Set 1 #

Patch Set 2 : updated to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -887 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Debug/expected-results.json View 1 chunk +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Release/expected-results.json View 1 chunk +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 1 chunk +10 lines, -14 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 chunk +10 lines, -14 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 1 chunk +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +8 lines, -20 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +10 lines, -22 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 1 chunk +12 lines, -30 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 1 chunk +12 lines, -30 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 1 chunk +12 lines, -30 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 1 chunk +12 lines, -30 lines 0 comments Download
M expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 1 chunk +2 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 1 chunk +2 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 1 chunk +10 lines, -22 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 1 chunk +10 lines, -22 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 1 chunk +10 lines, -22 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 1 chunk +10 lines, -22 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 1 1 chunk +6 lines, -15 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-23 13:38:27 UTC) #1
rmistry
LGTM (based on one or two trybot results)
6 years, 6 months ago (2014-06-23 13:39:38 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-23 15:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/349233004/20001
6 years, 6 months ago (2014-06-23 15:32:23 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 16:01:57 UTC) #5
Message was sent while issue was closed. 
Change committed as c8fd7b58c5c4004a7be73894c6b04eeabf932c23

Powered by Google App Engine
This is Rietveld 408576698