Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Unified Diff: Source/modules/webaudio/AudioNodeOutput.h

Issue 349213007: WebAudio: Remove AudioNode::RefType. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix webaudio/delaynode-max-nondefault-delay.html Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioNodeInput.cpp ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioNodeOutput.h
diff --git a/Source/modules/webaudio/AudioNodeOutput.h b/Source/modules/webaudio/AudioNodeOutput.h
index ade9c1c3350dbced00ad39f28ee870d246e7d95e..ad4ed32f2d39a5d487eeb92afae1fc56679de093 100644
--- a/Source/modules/webaudio/AudioNodeOutput.h
+++ b/Source/modules/webaudio/AudioNodeOutput.h
@@ -134,8 +134,11 @@ private:
// If m_isInPlace is true, use m_inPlaceBus as the valid AudioBus; If false, use the default m_internalBus.
bool m_isInPlace;
- HashSet<AudioNodeInput*> m_inputs;
- typedef HashSet<AudioNodeInput*>::iterator InputsIterator;
+ // This RefPtr<AudioNode> is connection reference. We must call AudioNode::
+ // makeConnection() after ref(), and call AudioNode::breakConnection()
+ // before deref().
+ HashMap<AudioNodeInput*, RefPtr<AudioNode> > m_inputs;
+ typedef HashMap<AudioNodeInput*, RefPtr<AudioNode> >::iterator InputsIterator;
bool m_isEnabled;
// For the purposes of rendering, keeps track of the number of inputs and AudioParams we're connected to.
« no previous file with comments | « Source/modules/webaudio/AudioNodeInput.cpp ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698