Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: Source/modules/webaudio/AudioNodeOutput.h

Issue 349213007: WebAudio: Remove AudioNode::RefType. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioNodeOutput.h
diff --git a/Source/modules/webaudio/AudioNodeOutput.h b/Source/modules/webaudio/AudioNodeOutput.h
index ade9c1c3350dbced00ad39f28ee870d246e7d95e..dee91da57fb29367a85ce70fb8fc6b0c2a2be4d4 100644
--- a/Source/modules/webaudio/AudioNodeOutput.h
+++ b/Source/modules/webaudio/AudioNodeOutput.h
@@ -136,6 +136,11 @@ private:
HashSet<AudioNodeInput*> m_inputs;
typedef HashSet<AudioNodeInput*>::iterator InputsIterator;
+ // The content of m_inputNodes should be synchronized with m_inputs.
+ // This RefPtr makes the node graph. We need to call AudioNode::
+ // wasConnected() after ref(), and call AudioNode::willBeDisconnected()
+ // before deref().
+ HashSet<RefPtr<AudioNode> > m_inputNodes;
Raymond Toy 2014/07/09 22:10:34 What is this hash table for? Why is this needed no
tkent 2014/07/10 08:07:42 This holds connection references, and replaces man
bool m_isEnabled;
// For the purposes of rendering, keeps track of the number of inputs and AudioParams we're connected to.

Powered by Google App Engine
This is Rietveld 408576698