Chromium Code Reviews| Index: Source/modules/webaudio/AudioBufferSourceNode.h |
| diff --git a/Source/modules/webaudio/AudioBufferSourceNode.h b/Source/modules/webaudio/AudioBufferSourceNode.h |
| index cb24a38c09abeaf47b8781f3a3c48fec9ed56821..4e91132db2412a96e75f09ada1647c62b37505d9 100644 |
| --- a/Source/modules/webaudio/AudioBufferSourceNode.h |
| +++ b/Source/modules/webaudio/AudioBufferSourceNode.h |
| @@ -130,9 +130,12 @@ private: |
| // It incorporates the base pitch rate, any sample-rate conversion factor from the buffer, and any doppler shift from an associated panner node. |
| double totalPitchRate(); |
| - // We optionally keep track of a panner node which has a doppler shift that is incorporated into |
| - // the pitch rate. We manually manage ref-counting because we want to use RefTypeConnection. |
| - PannerNode* m_pannerNode; |
| + // We optionally keep track of a panner node which has a doppler shift that |
| + // is incorporated into the pitch rate. |
| + // This RefPtr makes the node graph. We need to call AudioNode:: |
|
Raymond Toy
2014/07/09 22:10:33
What do you mean by "makes the node graph"?
tkent
2014/07/10 08:07:42
It means a connection type reference. I'll improv
|
| + // wasConnected() after ref(), and call AudioNode::willBeDisconnected() |
| + // before deref(). |
|
Raymond Toy
2014/07/09 22:10:33
Does this comment about wasConnected() and willBeD
tkent
2014/07/10 08:07:41
Right.
|
| + RefPtr<PannerNode> m_pannerNode; |
| // This synchronizes process() with setBuffer() which can cause dynamic channel count changes. |
| mutable Mutex m_processLock; |