WebAudio: Remove AudioNode::RefType.

Source/modules/webaudio/AudioNode.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 76 matching lines @@
     enum ChannelCountMode {
         Max,
         ClampedMax,
         Explicit
     };
 
     NodeType nodeType() const { return m_nodeType; }
     String nodeTypeName() const;
     void setNodeType(NodeType);
 
-    // We handle our own ref-counting because of the threading issues and subtle nature of
-    // how AudioNodes can continue processing (playing one-shot sound) after there are no more
-    // JavaScript references to the object.
-    enum RefType { RefTypeNormal, RefTypeConnection };
+    // Can be called from main thread or context's audio thread.
+    void ref();
+    void deref();
 
-    // Can be called from main thread or context's audio thread.
-    void ref(RefType refType = RefTypeNormal);
-    void deref(RefType refType = RefTypeNormal);
+    void wasConnected();

[Raymond Toy, 2014/07/09 22:10:34]

Add a comment on what wasConnected() does and when it should be called, like
what you have for willBeDisconnected().

[tkent, 2014/07/10 08:07:42]

Will do

+    // This will be disconnected from an object. This might have remaining
+    // connections from others.
+    // This function should be called before releasing connection-type

[Raymond Toy, 2014/07/09 22:10:34]

"should" or "must" be called?

[tkent, 2014/07/10 08:07:42]

must.  Will update.

+    // references.
+    void willBeDisconnected();
 
     // Can be called from main thread or context's audio thread.  It must be called while the context's graph lock is held.
-    void finishDeref(RefType refType);
+    void finishDeref();
 
     // The AudioNodeInput(s) (if any) will already have their input data available when process() is called.
     // Subclasses will take this input data and put the results in the AudioBus(s) of its AudioNodeOutput(s) (if any).
     // Called from context's audio thread.
     virtual void process(size_t framesToProcess) = 0;
 
     // No significant resources should be allocated until initialize() is called.
     // Processing may not occur until a node is initialized.
     virtual void initialize();
     virtual void uninitialize();
@@ skipping 101 matching lines @@
     GC_PLUGIN_IGNORE("http://crbug.com/353083")
     OwnPtr<Persistent<AudioNode> > m_keepAlive;
 #endif
 
     double m_lastProcessingTime;
     double m_lastNonSilentTime;
 
     // Ref-counting
     volatile int m_normalRefCount;
     volatile int m_connectionRefCount;
+    bool m_wasDisconnected;
 
     bool m_isMarkedForDeletion;
     bool m_isDisabled;
 
 #if DEBUG_AUDIONODE_REFERENCES
     static bool s_isNodeCountInitialized;
     static int s_nodeCount[NodeTypeEnd];
 #endif
 
 #if !ENABLE(OILPAN)
     virtual void refEventTarget() OVERRIDE FINAL { ref(); }
     virtual void derefEventTarget() OVERRIDE FINAL { deref(); }
 #endif
 
 protected:
     unsigned m_channelCount;
     ChannelCountMode m_channelCountMode;
     AudioBus::ChannelInterpretation m_channelInterpretation;
 };
 
 } // namespace WebCore
 
 #endif // AudioNode_h