WebAudio: Remove AudioNode::RefType.

Source/modules/webaudio/AudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 568 matching lines @@
         derefNode(m_finishedNodes[i]);
 
     m_finishedNodes.clear();
 }
 
 void AudioContext::refNode(AudioNode* node)
 {
     ASSERT(isMainThread());
     AutoLocker locker(this);
 
-    node->ref(AudioNode::RefTypeConnection);
     m_referencedNodes.append(node);
+    node->wasConnected();

[Raymond Toy, 2014/07/09 22:10:33]

Can we use a different name for wasConnected()? Every time I read that I keep
thinking it's asking if the node was connected, that that a node is being
connected.

[tkent, 2014/07/10 08:07:42]

How about didConnect?

[Raymond Toy, 2014/07/10 14:46:29]

I still read that as asking if the node did connect (to something).  How about
makeConnection?

 }
 
 void AudioContext::derefNode(AudioNode* node)
 {
     ASSERT(isGraphOwner());
 
-    node->deref(AudioNode::RefTypeConnection);
-
     for (unsigned i = 0; i < m_referencedNodes.size(); ++i) {
-        if (node == m_referencedNodes[i]) {
+        if (node == m_referencedNodes[i].get()) {
+            node->willBeDisconnected();
             m_referencedNodes.remove(i);

[Raymond Toy, 2014/07/09 22:10:33]

Would it make sense to have remove(i) call willBeDisconnected instead of doing
it here?

[tkent, 2014/07/10 08:07:42]

We can do it by adding a class wrapping a Vector.  However, I feel it's
overkill.
I'd like to keep this simpler because I'll update the code again and again.

[Raymond Toy, 2014/07/10 14:46:29]

Oh, right.  Yeah, keep it simple as it is.

             break;
         }
     }
 }
 
 void AudioContext::derefUnfinishedSourceNodes()
 {
     ASSERT(isMainThread());
     for (unsigned i = 0; i < m_referencedNodes.size(); ++i)
-        m_referencedNodes[i]->deref(AudioNode::RefTypeConnection);
+        m_referencedNodes[i]->willBeDisconnected();
 
     m_referencedNodes.clear();
 }
 
 void AudioContext::lock(bool& mustReleaseLock)
 {
     // Don't allow regular lock in real-time audio thread.
     ASSERT(isMainThread());
 
     ThreadIdentifier thisThread = currentThread();
@@ skipping 113 matching lines @@
         if (mustReleaseLock)
             unlock();
     }
 }
 
 void AudioContext::handleDeferredFinishDerefs()
 {
     ASSERT(isAudioThread() && isGraphOwner());
     for (unsigned i = 0; i < m_deferredFinishDerefList.size(); ++i) {
         AudioNode* node = m_deferredFinishDerefList[i];
-        node->finishDeref(AudioNode::RefTypeConnection);
+        node->finishDeref();
     }
 
     m_deferredFinishDerefList.clear();
 }
 
 void AudioContext::markForDeletion(AudioNode* node)
 {
     ASSERT(isGraphOwner());
 
     if (!isInitialized())
@@ skipping 199 matching lines @@
     visitor->trace(m_renderTarget);
     visitor->trace(m_destinationNode);
     visitor->trace(m_listener);
     visitor->trace(m_dirtySummingJunctions);
     EventTargetWithInlineData::trace(visitor);
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)