Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 349213002: Fix page set error message. (Closed)

Created:
6 years, 6 months ago by e.hakkinen
Modified:
6 years, 6 months ago
Reviewers:
nednguyen, marja
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix page set error message. A valid page set Python file must contain a page set class with suffix (not prefix) 'PageSet'. Fix error message accordingly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
e.hakkinen
6 years, 6 months ago (2014-06-23 09:26:18 UTC) #1
marja
lgtm
6 years, 6 months ago (2014-06-23 09:27:15 UTC) #2
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 6 months ago (2014-06-23 09:37:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/349213002/1
6 years, 6 months ago (2014-06-23 09:38:51 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 14:27:18 UTC) #5
Message was sent while issue was closed.
Change committed as 279104

Powered by Google App Engine
This is Rietveld 408576698