Use ScriptController to call callback in MediaQueryListListener

Use ScriptController to call callback in MediaQueryListListener

MediaQueryListListener uses invokeCallback which is in "V8Binding".
But it could use "ScriptController" directly. This change makes
invokeCallback could be removed from V8Binding.

BUG=388049
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176818

[kihong, 2014-06-24 03:51:20]

PTAL

[haraken, 2014-06-24 03:58:51]

LGTM.

https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
File Source/core/css/MediaQueryListListener.cpp (right):

https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
Source/core/css/MediaQueryListListener.cpp:42:
ScriptController::callFunction(m_scriptState.get()->executionContext(),
v8::Handle<v8::Function>::Cast(m_function.v8Value()),
m_scriptState.get()->context()->Global(), WTF_ARRAY_LENGTH(args), args,
m_scriptState.get()->isolate());

m_scriptState->context()->Global() will work.

m_scriptState->isolate() will work as well.

https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
File Source/core/css/MediaQueryListListener.h (right):

https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
Source/core/css/MediaQueryListListener.h:33: // FIXME: MediaQueryListListener
should be implemented using callback interface

Yes, and we should remove special-casing for MediaQueryListListener from the IDL
compiler. (See v8_types.py.)

[kihong, 2014-06-24 04:08:34]

On 2014/06/24 03:58:51, haraken wrote:
> LGTM.
> 
>
https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
> File Source/core/css/MediaQueryListListener.cpp (right):
> 
>
https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
> Source/core/css/MediaQueryListListener.cpp:42:
> ScriptController::callFunction(m_scriptState.get()->executionContext(),
> v8::Handle<v8::Function>::Cast(m_function.v8Value()),
> m_scriptState.get()->context()->Global(), WTF_ARRAY_LENGTH(args), args,
> m_scriptState.get()->isolate());
> 
> m_scriptState->context()->Global() will work.
> 
> m_scriptState->isolate() will work as well.

Sure, I will fix them for landing patch.

> 
>
https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
> File Source/core/css/MediaQueryListListener.h (right):
> 
>
https://codereview.chromium.org/349183006/diff/1/Source/core/css/MediaQueryLi...
> Source/core/css/MediaQueryListListener.h:33: // FIXME: MediaQueryListListener
> should be implemented using callback interface
> 
> Yes, and we should remove special-casing for MediaQueryListListener from the
IDL
> compiler. (See v8_types.py.)

OK, I will take a look at it. thanks :)

[kihong, 2014-06-24 04:29:42]

The CQ bit was checked by kihong.kwon@samsung.com

[commit-bot: I haz the power, 2014-06-24 04:30:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/349183006/20001

[commit-bot: I haz the power, 2014-06-24 05:33:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13239)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-24 06:36:38]

Change committed as 176818