Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/history/history_service.cc

Issue 349153006: Port HistoryService::QueryRedirects{From,To} to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index 2d8883c1d359139bd1d0763df5c7202960734ac6..cf113e9ad242b7c3bb0f8a16217d576dfc470ca1 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -797,22 +797,35 @@ base::CancelableTaskTracker::TaskId HistoryService::QueryHistory(
base::Bind(callback, base::Owned(query_results)));
}
-HistoryService::Handle HistoryService::QueryRedirectsFrom(
+base::CancelableTaskTracker::TaskId HistoryService::QueryRedirectsFrom(
const GURL& from_url,
- CancelableRequestConsumerBase* consumer,
- const QueryRedirectsCallback& callback) {
+ const QueryRedirectsCallback& callback,
+ base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- return Schedule(PRIORITY_UI, &HistoryBackend::QueryRedirectsFrom, consumer,
- new history::QueryRedirectsRequest(callback), from_url);
+ history::RedirectList* result = new history::RedirectList();
+ return tracker->PostTaskAndReply(
+ thread_->message_loop_proxy().get(),
+ FROM_HERE,
+ base::Bind(&HistoryBackend::QueryRedirectsFrom,
+ history_backend_.get(),
+ from_url,
+ base::Unretained(result)),
+ base::Bind(callback, base::Owned(result)));
}
-HistoryService::Handle HistoryService::QueryRedirectsTo(
+base::CancelableTaskTracker::TaskId HistoryService::QueryRedirectsTo(
const GURL& to_url,
- CancelableRequestConsumerBase* consumer,
- const QueryRedirectsCallback& callback) {
+ const QueryRedirectsCallback& callback,
+ base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- return Schedule(PRIORITY_NORMAL, &HistoryBackend::QueryRedirectsTo, consumer,
- new history::QueryRedirectsRequest(callback), to_url);
+ history::RedirectList* result = new history::RedirectList();
+ return tracker->PostTaskAndReply(thread_->message_loop_proxy().get(),
+ FROM_HERE,
+ base::Bind(&HistoryBackend::QueryRedirectsTo,
+ history_backend_.get(),
+ to_url,
+ base::Unretained(result)),
+ base::Bind(callback, base::Owned(result)));
}
HistoryService::Handle HistoryService::GetVisibleVisitCountToHost(
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698