Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/history/history_backend.h

Issue 349153006: Port HistoryService::QueryRedirects{From,To} to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 393cd1fe8c61983dc4765c7a9f1a64b674d5d0b7..276e34bf03e54e5423bbe1e97314ca22e106ad10 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -155,10 +155,19 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
void QueryHistory(const base::string16& text_query,
const QueryOptions& options,
QueryResults* query_results);
- void QueryRedirectsFrom(scoped_refptr<QueryRedirectsRequest> request,
- const GURL& url);
- void QueryRedirectsTo(scoped_refptr<QueryRedirectsRequest> request,
- const GURL& url);
+
+ // Computes the most recent URL(s) that the given canonical URL has
+ // redirected to. There may be more than one redirect in a row, so this
+ // function will fill the given array with the entire chain. If there are
+ // no redirects for the most recent visit of the URL, or the URL is not
+ // in history, the array will be empty.
+ void QueryRedirectsFrom(const GURL& url, RedirectList* redirects);
+
+ // Similar to above function except computes a chain of redirects to the
+ // given URL. Stores the most recent list of redirects ending at |url| in the
+ // given RedirectList. For example, if we have the redirect list A -> B -> C,
+ // then calling this function with url=C would fill redirects with {B, A}.
+ void QueryRedirectsTo(const GURL& url, RedirectList* redirects);
void GetVisibleVisitCountToHost(
scoped_refptr<GetVisibleVisitCountToHostRequest> request,
@@ -191,23 +200,6 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
int days_back,
MostVisitedURLList* result);
- // Computes the most recent URL(s) that the given canonical URL has
- // redirected to and returns true on success. There may be more than one
- // redirect in a row, so this function will fill the given array with the
- // entire chain. If there are no redirects for the most recent visit of the
- // URL, or the URL is not in history, returns false.
- //
- // Backend for QueryRedirectsFrom.
- bool GetMostRecentRedirectsFrom(const GURL& url,
- history::RedirectList* redirects);
-
- // Similar to above function except computes a chain of redirects to the
- // given URL. Stores the most recent list of redirects ending at |url| in the
- // given RedirectList. For example, if we have the redirect list A -> B -> C,
- // then calling this function with url=C would fill redirects with {B, A}.
- bool GetMostRecentRedirectsTo(const GURL& url,
- history::RedirectList* redirects);
-
// Favicon -------------------------------------------------------------------
void GetFavicons(
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698