Port HistoryService::QueryRedirects{From,To} to CancelableTaskTracker

chrome/browser/history/history_backend.cc

Index: chrome/browser/history/history_backend.cc
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
index 353fed3164d4b2d9168c6acb535b167a377e8341..f11559f9680349bcd914af1c408b9640c5414228 100644
--- a/chrome/browser/history/history_backend.cc
+++ b/chrome/browser/history/history_backend.cc
@@ -1274,22 +1274,14 @@ void HistoryBackend::QueryHistoryText(const base::string16& text_query,
 }
 
 // Frontend to GetMostRecentRedirectsFrom from the history thread.
-void HistoryBackend::QueryRedirectsFrom(
-    scoped_refptr<QueryRedirectsRequest> request,
-    const GURL& url) {
-  if (request->canceled())
-    return;
-  bool success = GetMostRecentRedirectsFrom(url, &request->value);
-  request->ForwardResult(request->handle(), url, success, &request->value);
+void HistoryBackend::QueryRedirectsFrom(const GURL& url,
+                                        QueryRedirectsResult* result) {
+  result->success = GetMostRecentRedirectsFrom(url, &result->redirects);

[droger, 2014/06/23 16:50:35]

codesearch seems partially broken so this may be wrong, but 
GetMostRecentRedirectsFrom() seems to be only called from here, maybe it would
make sense to actually inline it here?

Same for GetMostRecentRedirectsTo()

[sdefresne, 2014/06/24 13:41:00]

It's called multiple times from this file (at least three times), so I won't
inline it. GetMostRecentRedirectsTo is only called once, but there is a second
call that is commented and marked with a bug number to re-enable, so I'll also
leave the function untouched.

 }
 
-void HistoryBackend::QueryRedirectsTo(
-    scoped_refptr<QueryRedirectsRequest> request,
-    const GURL& url) {
-  if (request->canceled())
-    return;
-  bool success = GetMostRecentRedirectsTo(url, &request->value);
-  request->ForwardResult(request->handle(), url, success, &request->value);
+void HistoryBackend::QueryRedirectsTo(const GURL& url,
+                                      QueryRedirectsResult* result) {
+  result->success = GetMostRecentRedirectsTo(url, &result->redirects);
 }
 
 void HistoryBackend::GetVisibleVisitCountToHost(