Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 349153005: Revert of Revert of Fix SkPaint::measureText for stroked hairline text (Closed)

Created:
6 years, 6 months ago by rmistry
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@01-draw-fonts-nvpr-extract-state-procs
Visibility:
Public.

Description

Revert of Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/354433002/) Reason for revert: Rebaseline CL is ready to be submitted Original issue's description: > Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/) > > Reason for revert: > Caused many shadertext GM failures > > Original issue's description: > > Fix SkPaint::measureText for stroked hairline text > > > > SkPaint::measureText and text drawing used different criteria for > > determining whether text should be drawn as paths or not. > > > > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph > > positioning in the rendering. Mainly added in order to define what is the > > expected text rendering when hairline stroke is used with various transform > > options. > > > > The testcase also tries to note or highlight the fact that SkPaint::measureText > > is not expected to produce intuitively matching results when compared to a > > rendering, if the rendering is done so that the device ends up having a device > > transform. > > > > This fixes the glyph_pos_h_s (hairline, stroked) test-case. > > > > Ignore shadertext2_pdf-poppler.png gm on > > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails. > > > > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793 > > TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27 TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c4b84aef1adeb68bc853f35abb85b79fa1fcaac6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -14 lines) Patch
M expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -1 line 0 comments Download
A gm/glyph_pos.cpp View 1 chunk +204 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPaint.cpp View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Revert of Fix SkPaint::measureText for stroked hairline text
6 years, 6 months ago (2014-06-23 13:58:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/349153005/1
6 years, 6 months ago (2014-06-23 13:59:11 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 13:59:22 UTC) #3
Message was sent while issue was closed.
Change committed as c4b84aef1adeb68bc853f35abb85b79fa1fcaac6

Powered by Google App Engine
This is Rietveld 408576698