Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 349103002: Revert of Strip anonymous blocks when change in style removes need for them (Closed)

Created:
6 years, 6 months ago by rhogan
Modified:
6 years, 6 months ago
CC:
bemjb+rendering_chromium.org, blink-reviews, chrishtr, dsinclair, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), ojan, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Revert of Strip anonymous blocks when change in style removes need for them (https://codereview.chromium.org/253313005/) Reason for revert: Caused an incorrect cast in RenderBlockFlow. TBR=inferno@chromium.org,eae@chromium.org BUG=387211 Original issue's description: > Strip anonymous blocks when change in style removes need for them > > When a block element becomes a float or out of flow we should strip > any anonymous blocks wrapping its inline siblings. > > BUG=331251 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175220 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176779

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -168 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-continuation-on-line.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-other-block-on-line.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/block/strip-anonymous-blocks-when-block-child-becomes-float.html View 1 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/block/strip-anonymous-blocks-when-block-child-becomes-float-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-continuation-on-line-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-continuation-on-line-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-other-block-on-line-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-other-block-on-line-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rhogan
Created Revert of Strip anonymous blocks when change in style removes need for them
6 years, 6 months ago (2014-06-22 22:47:53 UTC) #1
rhogan
6 years, 6 months ago (2014-06-22 22:48:32 UTC) #2
eae
On 2014/06/22 22:48:32, rhogan wrote: LGTM
6 years, 6 months ago (2014-06-22 22:50:08 UTC) #3
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 6 months ago (2014-06-22 22:50:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/349103002/1
6 years, 6 months ago (2014-06-22 22:50:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-22 22:50:55 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-22 22:50:57 UTC) #7
robhogan (do not use)
lgtm
6 years, 6 months ago (2014-06-23 18:21:30 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 19:25:36 UTC) #9
Message was sent while issue was closed.
Change committed as 176779

Powered by Google App Engine
This is Rietveld 408576698