Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 349073004: Cleanup: Remove deprecated Profile::GetExtensionService(). (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, skanuj+watch_chromium.org, nkostylev+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, rginda+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, dominich, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, jennb, haitaol+watch_chromium.org, jianli, jfweitz+watch_chromium.org, oshima+watch_chromium.org, Jered, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, donnd+watch_chromium.org, Dmitry Titov, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove deprecated Profile::GetExtensionService(). BUG=104095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279995

Patch Set 1 : #

Patch Set 2 : rebase #

Total comments: 12

Patch Set 3 : address comments #

Patch Set 4 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -128 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_view_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 1 6 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 3 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 5 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/speech/tts_extension_loader_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 1 2 6 chunks +27 lines, -17 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 6 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-06-23 04:37:44 UTC) #1
Devlin
lgtm. You could also add BUG=104095 if you wanted to be complete. :) Thanks a ...
6 years, 6 months ago (2014-06-25 19:38:48 UTC) #2
Lei Zhang
https://codereview.chromium.org/349073004/diff/110001/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): https://codereview.chromium.org/349073004/diff/110001/chrome/browser/chromeos/offline/offline_load_page.cc#newcode90 chrome/browser/chromeos/offline/offline_load_page.cc:90: extension = extensions_service->extensions()->GetHostedAppByURL(url_); On 2014/06/25 19:38:48, Devlin wrote: > ...
6 years, 6 months ago (2014-06-25 19:58:31 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-25 19:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/349073004/130001
6 years, 6 months ago (2014-06-25 20:00:24 UTC) #5
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 6 months ago (2014-06-25 22:28:30 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-25 22:31:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/349073004/150001
6 years, 6 months ago (2014-06-25 22:32:38 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 13:26:41 UTC) #9
Message was sent while issue was closed. 
Change committed as 279995

Powered by Google App Engine
This is Rietveld 408576698