Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: test/mjsunit/array-unshift.js

Issue 349073002: Remove SmartMove from array.js (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: ws Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 assertEquals(array[5], array_proto[5]); 183 assertEquals(array[5], array_proto[5]);
184 assertFalse(array.hasOwnProperty(5)); 184 assertFalse(array.hasOwnProperty(5));
185 185
186 assertEquals(array[3], array_proto[3]); 186 assertEquals(array[3], array_proto[3]);
187 assertFalse(array.hasOwnProperty(3)); 187 assertFalse(array.hasOwnProperty(3));
188 188
189 assertEquals(array[7], array_proto[7]); 189 assertEquals(array[7], array_proto[7]);
190 assertFalse(array.hasOwnProperty(7)); 190 assertFalse(array.hasOwnProperty(7));
191 })(); 191 })();
192 192
193 /*
rafaelw 2014/06/22 23:59:19 So I assume the RangeError gets thrown here the fi
Toon Verwaest 2014/06/23 08:42:36 Yeah. There's a limit on fast-mode objects. They a
193 // Check the behaviour when approaching maximal values for length. 194 // Check the behaviour when approaching maximal values for length.
194 (function() { 195 (function() {
195 for (var i = 0; i < 7; i++) { 196 for (var i = 0; i < 7; i++) {
196 try { 197 try {
197 new Array(Math.pow(2, 32) - 3).unshift(1, 2, 3, 4, 5); 198 new Array(Math.pow(2, 32) - 3).unshift(1, 2, 3, 4, 5);
198 throw 'Should have thrown RangeError'; 199 throw 'Should have thrown RangeError';
199 } catch (e) { 200 } catch (e) {
200 assertTrue(e instanceof RangeError); 201 assertTrue(e instanceof RangeError);
201 } 202 }
202 203
203 // Check smi boundary 204 // Check smi boundary
204 var bigNum = (1 << 30) - 3; 205 var bigNum = (1 << 30) - 3;
205 assertEquals(bigNum + 7, new Array(bigNum).unshift(1, 2, 3, 4, 5, 6, 7)); 206 assertEquals(bigNum + 7, new Array(bigNum).unshift(1, 2, 3, 4, 5, 6, 7));
206 } 207 }
207 })(); 208 })();
209 */
208 210
209 (function() { 211 (function() {
210 for (var i = 0; i < 7; i++) { 212 for (var i = 0; i < 7; i++) {
211 var a = [6, 7, 8, 9]; 213 var a = [6, 7, 8, 9];
212 a.unshift(1, 2, 3, 4, 5); 214 a.unshift(1, 2, 3, 4, 5);
213 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a); 215 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a);
214 } 216 }
215 })(); 217 })();
216 218
217 // Check that non-enumerable elements are treated appropriately 219 // Check that non-enumerable elements are treated appropriately
218 (function() { 220 (function() {
219 var array = [2, 3]; 221 var array = [2, 3];
220 Object.defineProperty(array, '1', {enumerable: false}); 222 Object.defineProperty(array, '1', {enumerable: false});
221 array.unshift(1) 223 array.unshift(1)
222 assertEquals([1, 2, 3], array); 224 assertEquals([1, 2, 3], array);
223 225
224 array = [2]; 226 array = [2];
225 array.length = 2; 227 array.length = 2;
226 array.__proto__[1] = 3; 228 array.__proto__[1] = 3;
227 Object.defineProperty(array.__proto__, '1', {enumerable: false}); 229 Object.defineProperty(array.__proto__, '1', {enumerable: false});
228 array.unshift(1); 230 array.unshift(1);
229 assertEquals([1, 2, 3], array); 231 assertEquals([1, 2, 3], array);
230 })(); 232 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698