Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: test/mjsunit/array-shift2.js

Issue 349073002: Remove SmartMove from array.js (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: ws Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --allow-natives-syntax 5 // Flags: --allow-natives-syntax
6 6
7 Object.defineProperty(Array.prototype, "1", { 7 Object.defineProperty(Array.prototype, "1", {
8 get: function() { return "element 1"; }, 8 get: function() { return "element 1"; },
9 set: function(value) { } 9 set: function(value) { }
10 }); 10 });
11 function test(array) { 11 function test(array) {
12 array.shift(); 12 array.shift();
13 return array; 13 return array;
14 } 14 }
15 assertEquals(["element 1",2], test(["0",,2])); 15 assertEquals(["element 1","element 1"], test(["0",,2]));
rafaelw 2014/06/22 23:59:19 This test was actually wrong. Given that the prope
Toon Verwaest 2014/06/23 08:42:36 Sounds good and correct. On 2014/06/22 23:59:19,
16 assertEquals(["element 1",{}], test([{},,{}])); 16 assertEquals(["element 1","element 1"], test([{},,{}]));
17 %OptimizeFunctionOnNextCall(test); 17 %OptimizeFunctionOnNextCall(test);
18 assertEquals(["element 1",0], test([{},,0])); 18 assertEquals(["element 1","element 1"], test([{},,0]));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698