Remove SmartMove from array.js

test/mjsunit/array-functions-prototype-misc.js

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 /**
  * @fileoverview Test splice, shift, unshift, slice and join on small
  * and large arrays.  Some of these methods are specified such that they
  * should work on other objects too, so we test that too.
  */
 
+/*

[rafaelw, 2014/06/22 23:59:18]

This is currently testing the existing SmartMove code path in two dimensions:

1) By applying array methods to array-likes (line 94)
2) By putting a index property on the prototype (line 142)

These two are problematic only because of the size of the array(like)s used. My
suggestion is to alter this test to use a sufficiently small size for these two
paths.

[Toon Verwaest, 2014/06/23 08:42:36]

Sounds good for now.

We'll probably need to build a 4th optimization layer for dictionary mode
objects for splice, move, shift and unshift. But lets get it correct first. This
may cause regressions though, so we'll need to keep an eye on it.

On 2014/06/22 23:59:18, rafaelw wrote:

+
 var LARGE = 4000000;
 var VERYLARGE = 4000000000;
 
 // Nicer for firefox 1.5.  Unless you uncomment the following two lines,
 // smjs will appear to hang on this file.
 //var LARGE = 40000;
 //var VERYLARGE = 40000;
 
 var fourhundredth = LARGE/400;
 
@@ skipping 35 matching lines @@
     unshift_function = function(array, elt) {
       return array.unshift(elt);
     };
     unshift_function_2 = function(array, elt1, elt2) {
       return array.unshift(elt1, elt2);
     };
     shift_function = function(array) {
       return array.shift();
     };
   } else {
     // Don't run largest size on non-arrays or we'll be here for ever.

[Toon Verwaest, 2014/06/23 08:42:36]

.. ok :)

     poses.pop();
     new_function = function(length) {
       var obj = new PseudoArray();
       obj.length = length;
       return obj;
     };
     the_prototype = PseudoArray.prototype;
     push_function = function(array, elt) {
       array[array.length] = elt;
       array.length++;
@@ skipping 205 matching lines @@
 // Test http://b/issue?id=1202711
 arr = [0];
 arr.length = 2;
 Array.prototype[1] = 1;
 assertEquals(1, arr.pop());
 assertEquals(0, arr.pop());
 Array.prototype[1] = undefined;
 
 // Test http://code.google.com/p/chromium/issues/detail?id=21860
 Array.prototype.push.apply([], [1].splice(0, -(-1 % 5)));
+
+*/