content/browser/accessibility/browser_accessibility_manager_mac.mm - Issue 349033010: Implement accessible states and notifications for the tab strip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 349033010: Implement accessible states and notifications for the tab strip. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nvda_load_fix_3

Patch Set: Fix compile on other platforms Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/browser/accessibility/browser_accessibility_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_mac.mm

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm

index 53d776bc287536c0c13f608cb3846c9b6f07ae56..1a473bf0e38d406dc3af16844e39b77b977efecf 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -96,12 +96,6 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(

case ui::AX_EVENT_MENU_LIST_VALUE_CHANGED:

// Not used on Mac.

return;

- case ui::AX_EVENT_SHOW:

- // Not used on Mac.

- return;

- case ui::AX_EVENT_HIDE:

- // Not used on Mac.

- return;

case ui::AX_EVENT_ROW_COUNT_CHANGED:

event_id = NSAccessibilityRowCountChangedNotification;

break;

@@ -117,15 +111,9 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(

case ui::AX_EVENT_SELECTED_CHILDREN_CHANGED:

event_id = NSAccessibilitySelectedChildrenChangedNotification;

break;

- case ui::AX_EVENT_SELECTED_TEXT_CHANGED:

+ case ui::AX_EVENT_TEXT_SELECTION_CHANGED:

event_id = NSAccessibilitySelectedTextChangedNotification;

break;

- case ui::AX_EVENT_TEXT_INSERTED:

- // Not used on Mac.

- return;

- case ui::AX_EVENT_TEXT_REMOVED:

- // Not used on Mac.

- return;

case ui::AX_EVENT_VALUE_CHANGED:

event_id = NSAccessibilityValueChangedNotification;

break;