chrome/browser/ui/views/tabs/tab.cc - Issue 349033010: Implement accessible states and notifications for the tab strip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 349033010: Implement accessible states and notifications for the tab strip. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nvda_load_fix_3

Patch Set: Clarified that selected_indices is sorted Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc ('k') | chrome/browser/ui/views/tabs/tab_strip.cc » ('j') | ui/accessibility/ax_enums.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 2b4392ccd588810ba7dd052c5d4aa19c003d030d..c8f20102dd0e5074c1a6eaf993ecbb6756ddbf5f 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -976,6 +976,10 @@ void Tab::OnGestureEvent(ui::GestureEvent* event) {

void Tab::GetAccessibleState(ui::AXViewState* state) {

state->role = ui::AX_ROLE_TAB;

state->name = data_.title;

+ state->AddStateFlag(ui::AX_STATE_MULTISELECTABLE);

+ state->AddStateFlag(ui::AX_STATE_SELECTABLE);

+ if (IsSelected())

+ state->AddStateFlag(ui::AX_STATE_SELECTED);

}

////////////////////////////////////////////////////////////////////////////////