Issue 349033008: Fix standalone build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349033008: Fix standalone build. (Closed)

Created:
6 years, 5 months ago by jam

Modified:
6 years, 5 months ago

Reviewers:
jschuh

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Visibility:
Public.

More Reviews

Description

Fix standalone build. BUG=20 R=jschuh@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ad30f60

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/standalone.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jschuh

lgtm, assuming this is to make the safe numerics work by preventing windows.h from stomping ...

6 years, 5 months ago (2014-06-30 16:03:32 UTC) #2

jabdelmalek

6 years, 5 months ago (2014-06-30 16:26:14 UTC) #3

On 2014/06/30 16:03:32, Justin Schuh wrote:
> lgtm, assuming this is to make the safe numerics work by preventing windows.h
> from stomping on the STL min/max definitions.

yes. this is just for the standalone build. for building pdfium inside chromium,
this was already being done by build/common.gypi

Expand Messages | Collapse Messages