Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 349033007: Reland "Fix stack trace accessor behavior." (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Fix stack trace accessor behavior." BUG=v8:3404 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22166

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -143 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/heap.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/isolate.cc View 4 chunks +39 lines, -31 lines 0 comments Download
M src/messages.js View 1 5 chunks +45 lines, -72 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -18 lines 0 comments Download
M src/spaces.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-3404.js View 1 chunk +27 lines, -0 lines 0 comments Download
M test/mjsunit/runtime-gen/collectstacktrace.js View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/runtime-gen/getandclearoverflowedstacktrace.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +20 lines, -0 lines 0 comments Download
M test/mjsunit/stack-traces-overflow.js View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Second patch set is the fix.
6 years, 5 months ago (2014-06-30 15:33:30 UTC) #1
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-01 15:31:56 UTC) #2
Yang
6 years, 5 months ago (2014-07-02 14:18:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698