Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tests/language/factory_redirection_test.dart

Issue 34903006: Fix language tests for redirecting factories (issue 14297). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/factory_redirection_test.dart
===================================================================
--- tests/language/factory_redirection_test.dart (revision 29044)
+++ tests/language/factory_redirection_test.dart (working copy)
@@ -36,6 +36,8 @@
factory B.test04() = A.test04; /// 04: continued
factory B.test05(int incompatible) = A<T>.factory; /// 05: runtime error
+
+ factory B.test05(int incompatible) = A<T>.factory; /// 06: runtime error
}
class C<K, V> extends B<V> {
@@ -49,7 +51,7 @@
factory C.test04() = B.test04; /// 04: continued
- factory C.test06(int incompatible) = B<K>.test05; /// 06: runtime error
+ factory C.test06(int incompatible) = B<K>.test05; /// 06: continued
const factory C.test07(V x) = B<V>.A; /// 07: compile-time error
}
@@ -60,8 +62,8 @@
new A<List>.test03(); /// 03: continued
new C.test04(); /// 04: continued
new B.test05(0); /// 05: continued
- new C.test06<int, int>(0); /// 06: continued
- new C.test07<int, int>(0); /// 07: continued
+ new C<int, int>.test06(0); /// 06: continued
+ new C<int, int>.test07(0); /// 07: continued
Expect.isTrue(new A<List>() is A<List>);
Expect.isTrue(new A<bool>.constant(true).x);
Expect.isTrue(new A<Set>.factory() is B<Set>);
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/language/language_dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698