Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 349013002: Include Page.h in fewer headers (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, falken, horo+watch_chromium.org, jchaffraix+rendering, kenneth.christiansen, kinuko+worker_chromium.org, kinuko+fileapi, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, nhiroki, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, sof, tzik, vsevik+blink_chromium.org, Yoav Weiss, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Include Page.h in fewer headers This reduces the number of recompilation steps when touching: Page.h: 362 -> 262 UseCounter.h: 509 -> 431 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeRareData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NodeRareData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScopeProxyProvider.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScopeProxyProvider.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/quota/StorageQuotaClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/quota/StorageQuotaClient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseClient.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/PageWidgetDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/TextFinder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
6 years, 6 months ago (2014-06-21 21:10:09 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-22 00:16:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/349013002/1
6 years, 6 months ago (2014-06-22 00:17:15 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-22 01:17:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 176704

Powered by Google App Engine
This is Rietveld 408576698