LayoutTests/fast/media/media-query-list-listener-ordering.html - Issue 348893004: Rework MediaQueryMatcher to batch up listener notification

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/media/media-query-list-listener-ordering.html

Issue 348893004: Rework MediaQueryMatcher to batch up listener notification (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: ordering test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3

	4 <div id="sandbox"></div>

	5

	6 <script>

	7 description("Media query listeners should fire grouped by the MediaQueryList .");

	8

	9 var sandbox = document.getElementById("sandbox");

	10 var iframe = document.createElement("iframe");

	11 sandbox.appendChild(iframe);

	12

	13 var matchMedia = iframe.contentWindow.matchMedia;

	14 var mediaList1 = matchMedia("(max-width: 100px)");

	15 var mediaList2 = matchMedia("(max-width: 100px)");

	16 var mediaList3 = matchMedia("(max-width: 100px)");

	17

	18 var listenersCalled = [];

	19

	20 function makeListener(label) {

	21 return function() { listenersCalled.push(label); };

	22 }

	23

	24 mediaList3.addListener(makeListener("mediaList3_1"));

	25 mediaList2.addListener(makeListener("mediaList2_1"));

	26 mediaList1.addListener(makeListener("mediaList1_1"));

	27 mediaList2.addListener(makeListener("mediaList2_2"));

	28

	29 shouldBe("mediaList1.matches", "true");

	30 shouldBe("mediaList2.matches", "true");

	31 shouldBe("mediaList3.matches", "true");

	32

	33 // FIXME: You shouldn't need to touch offsetTop to force these updates.

	34

	35 iframe.style.width = "200px";

	36 iframe.offsetTop;

	37

	38 var expectedResult = ["mediaList1_1", "mediaList2_1", "mediaList2_2", "media List3_1"];

	39 shouldBe("listenersCalled", "expectedResult");

	40 </script>

OLD	NEW