Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 348843004: Fix potential deadlock situation for ChromeOS sounds. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
Reviewers:
dgreid, awong
CC:
chromium-reviews, feature-media-reviews_chromium.org, ygorshenin1
Project:
chromium
Visibility:
Public.

Description

Fix potential deadlock situation for ChromeOS sounds. Lock order was inverted while stopping the stream which can lead to deadlock. BUG=327817, 374135 TEST=No more lock inversion warning from TSANv2. R=ajwong@chromium.org, dgreid@chromium.org TBR=awong Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278885

Patch Set 1 #

Patch Set 2 : Remove suppressions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M base/debug/tsan_suppressions.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 6 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaleCurtis
dgreid: I think this may be the source of hangs reported on http://crbug.com/327817 WDYT?
6 years, 6 months ago (2014-06-20 20:27:20 UTC) #1
DaleCurtis
TBR=awong for base/debug/tsan_suppressions.cc update.
6 years, 6 months ago (2014-06-20 20:39:38 UTC) #2
awong
LGTM
6 years, 6 months ago (2014-06-20 20:40:38 UTC) #3
dgreid
On 2014/06/20 20:27:20, DaleCurtis wrote: > dgreid: I think this may be the source of ...
6 years, 6 months ago (2014-06-20 21:02:51 UTC) #4
dgreid
lgtm
6 years, 6 months ago (2014-06-20 21:09:03 UTC) #5
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-06-20 21:09:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/348843004/20001
6 years, 6 months ago (2014-06-20 21:12:28 UTC) #7
DaleCurtis
6 years, 6 months ago (2014-06-21 01:07:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r278885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698