Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 348833005: [DO NOT COMMIT] Random hacks to unblock work on replication. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More random hacks, including also dcheng's https://codereview.chromium.org/346403002 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/geolocation/GeolocationController.cpp ('k') | Source/web/WebFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 6ce09ebc41cc2a801a73e7cc1b49dea998855db0..357617096656c3405cbf671b62ddb1811ba48459 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -365,7 +365,7 @@ void ChromeClientImpl::setResizable(bool value)
bool ChromeClientImpl::shouldReportDetailedMessageForSource(const String& url)
{
WebLocalFrameImpl* webframe = m_webView->mainFrameImpl();
- return webframe->client() && webframe->client()->shouldReportDetailedMessageForSource(url);
+ return webframe && webframe->client() && webframe->client()->shouldReportDetailedMessageForSource(url);
}
void ChromeClientImpl::addMessageToConsole(LocalFrame* localFrame, MessageSource source, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace)
@@ -837,6 +837,10 @@ void ChromeClientImpl::handleKeyboardEventOnTextField(HTMLInputElement& inputEle
void ChromeClientImpl::forwardInputEvent(
WebCore::Frame* frame, WebCore::Event* event)
{
+ // FIXME: Break input events for now, but don't crash.
+ if (frame->isRemoteFrame()) {
+ return;
+ }
WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(toLocalFrameTemporary(frame));
// This is only called when we have out-of-process iframes, which
« no previous file with comments | « Source/modules/geolocation/GeolocationController.cpp ('k') | Source/web/WebFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698