[DO NOT COMMIT] Random hacks to unblock work on replication.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 #include "core/editing/FrameSelection.h"
 #include "core/editing/InputMethodController.h"
 #include "core/editing/TextIterator.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/events/WheelEvent.h"
 #include "core/frame/EventHandlerRegistry.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/PinchViewport.h"
+#include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
 #include "core/frame/SmartClip.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/ime/InputMethodContext.h"
 #include "core/inspector/InspectorController.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoader.h"
@@ skipping 1515 matching lines @@
         return;
 
     page()->frameHost().pinchViewport().setSize(newSize);
 }
 
 void WebViewImpl::resize(const WebSize& newSize)
 {
     if (m_shouldAutoResize || m_size == newSize)
         return;
 
+    if (!mainFrameImpl())

[dcheng, 2014/06/20 20:49:12]

Being less familiar with the rendering paths, is this something we're going to
need to handle for mirrored roots eventually? I feel like there are a lot of
locations that depend on a top-level FrameView, and I'm not sure we have a good
story for them yet.

[nasko, 2014/06/20 21:09:53]

I'll leave that for Ken to give input on.

[kenrb, 2014/06/23 15:21:18]

Most of the places that access the top-level FrameView can be changed to instead
access the FrameView of the local Frame root (i.e. root of a connected subtree
of LocalFrames). For rendering that is typically going to be the case, anyway.
Certainly that is the case here, where the FrameView is being used to start a
layout.

I expect there to be exceptions but we can deal with those as we find them.

+        return;
+
     FrameView* view = mainFrameImpl()->frameView();
     if (!view)
         return;
 
     WebSize oldSize = m_size;
     float oldPageScaleFactor = pageScaleFactor();
     int oldContentsWidth = contentsSize().width();
 
     m_size = newSize;
 
@@ skipping 502 matching lines @@
         return false;
     *location = plainTextRange.start();
     *length = plainTextRange.length();
     return true;
 }
 
 WebTextInputInfo WebViewImpl::textInputInfo()
 {
     WebTextInputInfo info;
 
-    LocalFrame* focused = toLocalFrame(focusedWebCoreFrame());
+    Frame* focusedFrame = focusedWebCoreFrame();
+    if (focusedFrame->isRemoteFrame())
+        return info;
+
+    LocalFrame* focused = toLocalFrame(focusedFrame);
     if (!focused)
         return info;
 
     FrameSelection& selection = focused->selection();
     Node* node = selection.selection().rootEditableElement();
     if (!node)
         return info;
 
     info.inputMode = inputModeOfFocusedElement();
 
@@ skipping 394 matching lines @@
         relativeToFrame = mainFrame();
     Frame* frame = toWebLocalFrameImpl(relativeToFrame)->frame();
     frame = frame->tree().find(name);
     if (!frame || !frame->isLocalFrame())
         return 0;
     return WebLocalFrameImpl::fromFrame(toLocalFrame(frame));
 }
 
 WebFrame* WebViewImpl::focusedFrame()
 {
-    return WebLocalFrameImpl::fromFrame(toLocalFrame(focusedWebCoreFrame()));
+    Frame* frame = focusedWebCoreFrame();
+    if (frame->isRemoteFrame())

[dcheng, 2014/06/20 20:49:12]

You can use WebFrame::fromFrame now, so you don't have to do this awkward check
(since the awkwardness is now centralized =)

[nasko, 2014/06/20 21:09:53]

Yay! ?!

+        return WebRemoteFrameImpl::fromFrame(toRemoteFrame(*frame));
+    return WebLocalFrameImpl::fromFrame(toLocalFrame(frame));
 }
 
 void WebViewImpl::setFocusedFrame(WebFrame* frame)
 {
     if (!frame) {
         // Clears the focused frame if any.
         Frame* focusedFrame = focusedWebCoreFrame();
         if (focusedFrame && focusedFrame->isLocalFrame())
             toLocalFrame(focusedFrame)->selection().setFocused(false);
         return;
@@ skipping 1616 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink