Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 348803004: Revert of Isolate nacl_loader_unittests (Closed)

Created:
6 years, 6 months ago by vsevik
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Isolate nacl_loader_unittests (https://codereview.chromium.org/322333006/) Reason for revert: This is causing the following error when running gyp_chromium with disable_nacl=1: Traceback (most recent call last): File "./build/gyp_chromium", line 314, in <module> gyp_rc = gyp.main(args) File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 527, in main return gyp_main(args) File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 503, in gyp_main options.circular_check) File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 129, in Load params['parallel'], params['root_targets']) File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 2759, in Load RemoveLinkDependenciesFromNoneTargets(targets) File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 1483, in RemoveLinkDependenciesFromNoneTargets if targets[t].get('variables', {}).get('link_dependency', 0): KeyError: '/chromium/src/components/nacl.gyp:nacl_loader_unittests#target' Original issue's description: > Isolate nacl_loader_unittests > > Isolate the Linux-only nacl_loader_unittests. > > BUG=384515 > TBR=maruel > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278620 TBR=vadimsh@chromium.org,mseaborn@chromium.org,maruel@chromium.org,jln@chromium.org NOTREECHECKS=true NOTRY=true BUG=384515 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M components/nacl.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D components/nacl_loader_unittests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of Isolate nacl_loader_unittests
6 years, 6 months ago (2014-06-20 07:43:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/348803004/1
6 years, 6 months ago (2014-06-20 07:45:17 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 07:47:59 UTC) #3
Message was sent while issue was closed.
Change committed as 278643

Powered by Google App Engine
This is Rietveld 408576698