Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/socket/server_socket.h

Issue 348803003: Refactor tcp socket and unix domain socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix net_unittests for iOS Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/server_socket.h
diff --git a/net/socket/server_socket.h b/net/socket/server_socket.h
index 11151eea1539636928b64aee65876dfacd9e60ec..74721a884c2004b811e0f483b38d45ee88b28781 100644
--- a/net/socket/server_socket.h
+++ b/net/socket/server_socket.h
@@ -16,17 +16,25 @@ class StreamSocket;
class NET_EXPORT ServerSocket {
public:
- ServerSocket() { }
- virtual ~ServerSocket() { }
+ ServerSocket();
+ virtual ~ServerSocket();
- // Bind the socket and start listening. Destroy the socket to stop
+ // Binds the socket and start listening. Destroy the socket to stop
// listening.
virtual int Listen(const net::IPEndPoint& address, int backlog) = 0;
+ // Binds the socket with address and port, and start listening. It expects
+ // a vaild IPv4 or IPv6 address. Otherwise, it returns ERR_ADDRESS_INVALID.
+ // Subclasses may override this function if |address_string| is in a different
+ // format, for example, unix domain socket path.
+ virtual int ListenWithAddressAndPort(const std::string& address_string,
mmenke 2014/06/26 15:36:10 need to include <string>
byungchul 2014/06/26 18:09:23 Done.
+ int port,
+ int backlog);
+
// Gets current address the socket is bound to.
virtual int GetLocalAddress(IPEndPoint* address) const = 0;
- // Accept connection. Callback is called when new connection is
+ // Accepts connection. Callback is called when new connection is
// accepted.
virtual int Accept(scoped_ptr<StreamSocket>* socket,
const CompletionCallback& callback) = 0;
« no previous file with comments | « net/net.gypi ('k') | net/socket/server_socket.cc » ('j') | net/socket/socket_libevent.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698