Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: extensions/browser/api/socket/tcp_socket.cc

Issue 348803003: Refactor tcp socket and unix domain socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert the behavior change of calling RecordFastOpenStatus() Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/tcp_socket.cc
diff --git a/extensions/browser/api/socket/tcp_socket.cc b/extensions/browser/api/socket/tcp_socket.cc
index 49f17dcf418d2324b13527353ab0d2eee2f9ec4c..12de56f73683543a344c2ef10ae35b6365fdddd0 100644
--- a/extensions/browser/api/socket/tcp_socket.cc
+++ b/extensions/browser/api/socket/tcp_socket.cc
@@ -196,14 +196,10 @@ int TCPSocket::Listen(const std::string& address,
DCHECK(!socket_.get());
socket_mode_ = SERVER;
- scoped_ptr<net::IPEndPoint> bind_address(new net::IPEndPoint());
- if (!StringAndPortToIPEndPoint(address, port, bind_address.get()))
- return net::ERR_INVALID_ARGUMENT;
-
if (!server_socket_.get()) {
server_socket_.reset(new net::TCPServerSocket(NULL, net::NetLog::Source()));
}
- int result = server_socket_->Listen(*bind_address, backlog);
+ int result = server_socket_->ListenWithAddressAndPort(address, port, backlog);
if (result)
*error_msg = kSocketListenError;
return result;

Powered by Google App Engine
This is Rietveld 408576698